Ticket #825 (new defect)

Opened 3 months ago

Last modified 4 days ago

[PATCH] received in opie_qcop.c:get_line() will not get the return value of read()

Reported by: microe Assigned to: paule
Priority: normal Milestone: 0.40
Component: Plugin: opie Version: 0.38
Severity: normal Keywords:
Cc:

Description

received in opie_qcop.c:get_line() is going to get assigned the evaluation of the whole conditional because the parens are not quite right. The test inside the while loop will never execute because received can never be -1.

Attachments

missing-parens (0.9 kB) - added by microe on 08/22/08 01:57:42.
puts parens around received = read() so that received gets assigned correctly

Change History

08/22/08 01:57:42 changed by microe

  • attachment missing-parens added.

puts parens around received = read() so that received gets assigned correctly

11/16/08 14:05:55 changed by felixmoeller

  • version changed from 0.37 to 0.38.

this patch is not yet in source:/plugins/opie-sync/src/opie_qcop.c

paule as you commit all the others, did you review this one?