Ticket #82 (closed defect: fixed)

Opened 3 years ago

Last modified 3 months ago

replace literals with #defines in the xml formats

Reported by: abauer Assigned to: bricks
Priority: high Milestone: 0.37
Component: OpenSync Version: 0.31
Severity: minor Keywords:
Cc:

Description

see attached patch.

Attachments

opensync-xml-contact.h (3.3 kB) - added by abauer on 04/26/05 23:47:39.

Change History

04/26/05 23:47:39 changed by abauer

  • attachment opensync-xml-contact.h added.

05/20/05 08:46:20 changed by twogood

I have comitted (a slightly updated version of) opensync-xml-contact.h to formats/vformats-xml/ but I haven't updated xml-vcard.c.

08/28/06 14:51:59 changed by cstender

  • milestone deleted.

Milestone Beta deleted

09/07/06 16:48:09 changed by abauer

  • priority changed from normal to low.
  • status changed from new to assigned.
  • version set to 0.31.
  • severity changed from normal to minor.

10/16/07 00:21:10 changed by dgollub

  • owner changed from abauer to dgollub.
  • priority changed from low to high.
  • status changed from assigned to new.
  • milestone set to OpenSync 0.40.

06/12/08 17:01:10 changed by dgollub

  • milestone changed from 0.40 to 0.37.

Still useful even if this has only little impact on the xmlformat plugin (./formats/xmlformat.c). We should provide for each format a header which literals defined, so format plugins converting to xmlformats can include them.

The literal strings which should get defined could be find the the XML Schemas.

06/19/08 09:37:33 changed by bricks

  • owner changed from dgollub to bricks.

Where should the files be added (e.g. formats/xmlformat-note.h or opensync/xmlformat/xmlformat-note.h)?

06/19/08 09:43:08 changed by dgollub

Since this is actually directly tied to the xmlforamt plugin:./formats/xmlformat-$objtype.h

07/07/08 17:13:19 changed by dgollub

Implementation by bricks: r3380, r3381, r3382, r3383, r3384

Bjoern, i guess the implementation is completed - is it? Can we mark this as fixed?

07/09/08 19:27:03 changed by bricks

  • status changed from new to closed.
  • resolution set to fixed.

Should be complete, but needs more comments.