[PATCH] pointer checks

[microe]

1. At line 210 of opensync_merger.c new_node is checked for null. Then

at line 213 new_node is dereferenced to get the doc pointer for the destination doc.

Remove call (and commented out call).

2. In opensync_xml.c at line 219 the two pointers are compared. But at

line 223 they are checked for null. Since strcmp will dereference both pointers to compare their strings this would cause a segfault.

Move the pointer test to before the strcmp.

3. In opensync_serializer.c auth is checked when *auth was the pointer

that was actually given the allocated authentication object.

Change the check to *auth.

[microe]

Fixes three pointer check defects in opensync (in trunk)

[microe]

Expanded patch. Same theme - fixes defective pointer checks (or adds them)

[dgollub]

Very impressive catches! Just curious - how did you find all those nasty bugs?

Testsuite is running on the patched build...

[dgollub]

Thanks a lot! Committed - r3537

[microe]

I didn't find them. Coverity prevent did. Thanks.

[dgollub]

Replying to microe:

I didn't find them. Coverity prevent did. Thanks.

I see - does Coverity report more issue? How did you got access to Coverity - i heard OSS projects can apply for an audit.

[microe]

prevent does not report anything else. And the analysis was set to check everything.

You can apply. And now that opensync is pretty much clear of defects it can go up to a ring or two if it is selected.