Ticket #732 (new enhancement)

Opened 5 months ago

Last modified 2 months ago

[PATCH] two tiny patches for moto-sync

Reported by: floe Assigned to: andrewb
Priority: normal Milestone:
Component: Plugin: moto Version: 0.35
Severity: normal Keywords:
Cc:

Description

Hi, I'm using 0.36 with moto-sync from SVN and had two issues. First, there's still a reference to hashtable.reset_reports(), which doesn't exist. Second, there's some confusion WRT to timezone-aware and timezone-agnostic date values, leading to a "TypeError?: can't compare offset-naive and offset-aware datetimes".

Yours, Florian

Attachments

moto-sync-patch (0.9 kB) - added by floe on 04/30/08 11:26:16.

Change History

04/30/08 11:26:16 changed by floe

  • attachment moto-sync-patch added.

05/05/08 13:41:24 changed by floe

  • version changed from 0.22 to 0.35.

Hm, and here's another one:

@@ -611,7 +611,8 @@

elif repeat_type == MOTO_REPEAT_WEEKLY:

appendXMLTag(doc, e, 'Frequency', 'WEEKLY') if repeat_day:

- repeat_days = moto_repeat_day_to_weekdays(repeat_day, eventdt.weekday()).sort() + repeat_days = moto_repeat_day_to_weekdays(repeat_day, eventdt.weekday()) + repeat_days.sort()

appendXMLTag(doc, e, 'ByDay?', ','.join([VCAL_DAYS[n] for n in repeat_days]))

else:

repeat_days = []

Calling .sort() on a list does an in-place sort and returns None, so this is the correct way.

08/09/08 21:59:36 changed by felixmoeller

  • summary changed from two tiny patches for moto-sync to [PATCH] two tiny patches for moto-sync.

08/15/08 19:52:18 changed by dgollub

The hashtable patch-hunk is valid i think. Not quite sure about the timestamp hunk.

floe, could you give some information about your device - so we can try to reproduce the issue? andrewb, could you review the RRULE and timestamp related changes? are those good to go?

08/18/08 09:56:45 changed by floe

I have a Razr V3xx. But I believe all three bugs are independent of the device..