Ticket #731 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

Segfault in file-sync plugin when deleting files

Reported by: paule Assigned to: dgollub
Priority: normal Milestone:
Component: Plugin: file-sync Version:
Severity: normal Keywords:
Cc:

Description

Using latest SVN I set up a simple file-sync <-> opie-sync group (with only the "event" type enabled), created some event data on the Opie side, and then synced until no changes were reported. Then I deleted one of the event vcard files on the file-sync side and synced again, which resulted in a segfault (trace and valgrind output attached).

Attachments

crash_traces.tar.gz (24.2 kB) - added by paule on 04/28/08 14:34:11.
crash_output.txt (37.1 kB) - added by paule on 04/28/08 14:35:10.

Change History

04/28/08 14:34:11 changed by paule

  • attachment crash_traces.tar.gz added.

04/28/08 14:35:10 changed by paule

  • attachment crash_output.txt added.

04/28/08 14:40:01 changed by paule

Oops, I meant vevent, not vcard.

05/03/08 00:14:16 changed by dgollub

  • status changed from new to closed.
  • resolution set to fixed.

Should be fixed with r3304.

Thanks for testing!

--- src/file_sync.c (revision 3299) +++ src/file_sync.c (working copy) @@ -594,7 +594,7 @@

osync_filesync_report_dir(dir, info, NULL, ctx);

OSyncList *u, *uids = osync_hashtable_get_deleted(dir->hashtable);

- for (u = uids; uids; u = u->next) { + for (u = uids; u; u = u->next) {

OSyncChange *change = osync_change_new(&error); if (!change) {

osync_context_report_osyncwarning(ctx, error);