file-sync plug-in produces GLib errors on empty files

[Lemur]

SUMMARY:
Got the following error during syncronization:

(process:11776): GLib-CRITICAL **: g_pattern_match: assertion `string != NULL' failed

TO REPRODUCE:

1. Follow the steps under Test File-File Synchronization? in the Setup Guide (up to the section titled "First Test: Empty Directories")
2. Enter these commands, and note the output

   $ touch sync1/empty-file
   $ msynctool --sync filefile
   

Output:

Synchronizing group "filefile"
Member 2 of type file-sync just connected
Member 1 of type file-sync just connected
All clients connected or error

(process:11776): GLib-CRITICAL **: g_pattern_match: assertion `string != NULL' failed

(process:11776): GLib-CRITICAL **: g_pattern_match: assertion `string != NULL' failed

(process:11776): GLib-CRITICAL **: g_pattern_match: assertion `string != NULL' failed

(process:11776): GLib-CRITICAL **: g_pattern_match: assertion `string != NULL' failed
Received an entry empty-file with data of size 24 from member 1. Changetype ADDED
Member 1 of type file-sync just sent all changes
Member 2 of type file-sync just sent all changes
All clients sent changes or error
All conflicts have been reported
Member 1 of type file-sync committed all changes.
Sent an entry empty-file of size 24 to member 2. Changetype ADDED
Member 2 of type file-sync committed all changes.
All clients have written
Member 1 of type file-sync just disconnected
Member 2 of type file-sync just disconnected
All clients have disconnected
The sync was successful

[chi70]

I assume the setup guide is http://www.opensync.org/wiki/SetupGuide-0.30 I will follow these instructions with trunk and resolve the ticket if the errors are gone there.

[tuju]

actually currently here:

http://www.opensync.org/wiki/docs/trunk

but we're just talking about how the whole web should be organized. You can always find them from index? anyway.

Hmmmm... are you aware that this was reported against 0.22? If this still applies to current trunk, please set it to 0.38/latest.

[chi70]

I followed the instructions in http://www.opensync.org/wiki/SetupGuide-0.30 here the output

chris@urania:/opt/opensync$ osynctool --addgroup filefile-677
chris@urania:/opt/opensync$ osynctool --addmember filefile-677 file-sync
chris@urania:/opt/opensync$ osynctool --addmember filefile-677 file-sync
chris@urania:/opt/opensync$ mkdir /tmp/s1 /tmp/s2
chris@urania:/opt/opensync$ osynctool  --configure filefile-677 1
chris@urania:/opt/opensync$ osynctool  --configure filefile-677 2
chris@urania:/opt/opensync$
chris@urania:/opt/opensync$ osynctool --sync filefile-677
Synchronizing group "filefile-677"
ERROR: No synchronizable objtype
EXIT_ERROR: osync_engine_initialize: No synchronizable objtype
EXIT_ERROR: osynctool_synchronize: No synchronizable objtype
ERROR: No synchronizable objtype

looks OK to me

chris@urania:/opt/opensync$ osynctool --discover filefile-677
Discovered Objtypes:
        data
                Format: file
Discovered Objtypes:
        data
                Format: file
chris@urania:/tmp$ touch /tmp/s2/emptyfile
chris@urania:/tmp$ ls -l /tmp/s1 /tmp/s2
/tmp/s1:
total 0

/tmp/s2:
total 0
-rw-r--r-- 1 chris users 0 Dec  2 23:11 emptyfile
chris@urania:/tmp$ osynctool --sync filefile-677
Synchronizing group "filefile-677"
data sink of member 2 of type file-sync just connected
Main sink of member 2 of type file-sync just connected
data sink of member 1 of type file-sync just connected
Main sink of member 1 of type file-sync just connected
All clients connected or error
data sink of member 1 of type file-sync just sent all changes
Main sink of member 1 of type file-sync just sent all changes
Received an entry emptyfile from member 2 (file-sync). Changetype ADDED
data sink of member 2 of type file-sync just sent all changes
Main sink of member 2 of type file-sync just sent all changes
All clients sent changes or error
All conflicts have been reported
data sink of member 2 of type file-sync committed all changes.
Main sink of member 2 of type file-sync committed all changes.
Sent an entry emptyfile to member 1 (file-sync). Changetype ADDED
data sink of member 1 of type file-sync committed all changes.
Main sink of member 1 of type file-sync committed all changes.
All clients have written
data sink of member 1 of type file-sync reported sync done.
Main sink of member 1 of type file-sync reported sync done.
data sink of member 2 of type file-sync reported sync done.
Main sink of member 2 of type file-sync reported sync done.
All clients reported sync done
The sync was successful
data sink of member 2 of type file-sync just disconnected
Main sink of member 2 of type file-sync just disconnected
data sink of member 1 of type file-sync just disconnected
Main sink of member 1 of type file-sync just disconnected
All clients have disconnected
chris@urania:/tmp$ ls -l /tmp/s1 /tmp/s2
/tmp/s1:
total 0
-rw-r--r-- 1 chris users 0 Dec  2 23:11 emptyfile

/tmp/s2:
total 0
-rw-r--r-- 1 chris users 0 Dec  2 23:11 emptyfile
chris@urania:/tmp$                                                                                 

closing as fixed in trunk.

Feel free to reopen if its reproducible in trunk.