Ticket #209 (closed defect: fixed)

Opened 2 years ago

Last modified 1 year ago

Filesync needs to handle UIDs containing /

Reported by: Graham Cobb Assigned to: dgollub
Priority: high Milestone: 0.21
Component: Plugin: file Version:
Severity: critical Keywords:
Cc:

Description

The file-sync plugin tries to use the change UID as the filename (and vice-versa). This does not work when the UID contains a / (kdepim can do this -- it occurs with one of my Knotes).

The attached patch causes the file-sync plugin to use a (reversible) quoting scheme to encode / so that it does not appear in the filename but will map to the correct UID. This scheme has no effect on normal filenames which use only printable characters.

Graham

Attachments

grc-file-sync-escape-filenames.patch (4.5 kB) - added by Graham Cobb on 06/17/06 16:03:58.

Change History

06/17/06 16:03:58 changed by Graham Cobb

  • attachment grc-file-sync-escape-filenames.patch added.

06/17/06 16:04:55 changed by Graham Cobb

  • component changed from OpenSync to FileSync-Plugin.

06/22/06 15:25:19 changed by ehabkost

We've had on IRC an extensive discussion about the possible solutions for this problem. The log is on FilenamesAndUIdsDiscussion.

06/22/06 15:27:03 changed by ehabkost

Uh... the wiki link didn't work in my previous comment. The log is here: FilenamesAndUIdsDiscussion.

06/22/06 15:29:22 changed by ehabkost

  • owner changed from abauer to ehabkost.

Taking the ticket to me.

08/23/06 23:21:04 changed by Graham Cobb

  • priority changed from normal to high.
  • version set to 0.19.
  • severity changed from major to critical.

This still occurs in the current SVN version (1145). I believe this should be a blocker for the V0.19 release as it prevents a simple kdepim to file synchronisation working if you are unlucky in the UIDs used for the kdepim objects.

Graham

09/07/06 18:05:21 changed by abauer

  • owner changed from ehabkost to abauer.
  • status changed from new to assigned.

09/08/06 23:38:59 changed by abauer

  • status changed from assigned to closed.
  • resolution set to fixed.

11/08/06 20:40:38 changed by Graham Cobb

  • status changed from closed to reopened.
  • version deleted.
  • resolution deleted.

This bug still exists in the latest SVN (1461). It still causes any attempt for me to synchronise between kdepim and file-sync to fail unless I apply the patch I attached above.

One of the other solutions that have been discussed could be adopted but some solution is needed! If this problem is rare (I seem to be the only person who has reported it) then just use my patch -- it works well for Unix systems and could not be worse than the current situation.

For further information, in my case, one of my kdepim entries has URL AQQAAAABCgw/AAAAAAAAAAAAAAAA and generates the following error: 

Error writing entry AQQAAAABCgw/AAAAAAAAAAAAAAAA to member 1 (file-sync): Unable to open file /tmp/sync1/AQQAAAABCgw/AAAAAAAAAAAAAAAA
 for writing: No such file or directory
Mapping Write Error: Unable to open file /tmp/sync1/AQQAAAABCgw/AAAAAAAAAAAAAAAA for writing: No such file or directory

02/07/07 15:04:54 changed by dgollub

  • owner changed from abauer to dgollub.
  • status changed from reopened to new.
  • milestone set to 0.21.

02/13/07 22:42:01 changed by pmarat

  • status changed from new to closed.
  • resolution set to fixed.

kdepim notes are now using md5 for hash