Ticket #1206 (closed defect: fixed)

Opened 7 months ago

Last modified 7 months ago

[PATCH] Merger disable / unavailable

Reported by: nicklas Owned by: dgollub
Priority: high Milestone: OpenSync 0.40
Component: OpenSync: Engine Version: 0.39
Severity: major Keywords:
Cc:

Description

Hi,

I have an issue ; I propse a solution, but I don't know it's the best solution :(

_osync_obj_engine_clone_and_demerge_change has to be called only if the user has configured the merger feature : --enable-merger

As merger feature isn't available, I have disabled this feature, but I notice that this function is always called and of course, I get an error :

"Couldn't handle the capabilities in format"

So I propose a little patch to fix this.

Regards,

Nicolas

Attachments

opensync-patch.diff Download (1.4 KB) - added by nicklas 7 months ago.

Change History

Changed 7 months ago by nicklas

comment:1 Changed 7 months ago by dgollub

  • Status changed from new to assigned
  • Summary changed from Patch - Merger disable / unavailable to [PATCH] Merger disable / unavailable

comment:2 Changed 7 months ago by dgollub

  • Status changed from assigned to closed
  • Resolution set to fixed

(In [6027]) Don't call _osync_obj_engine_clone_and_demerge_change() in _osync_obj_engine_mapping_find() if the merge is disabled by the group configuration. Otherwise this would cause:

"Couldn't handle the capabilities in format"

Patch by Nicolas, fixes #1206

Note: See TracTickets for help on using tickets.