vformat being parsed as though it were XML

[Graham Cobb]

GPE-to-file sync was working last night and GPE has not changed but with revision 5006 (including the xmlformat changes) it has now broken. I get the following error reported (once for each record read from GPE):

Main sink of member 2 of type gpe-sync had an error: Could not parse XML.
Entity: line 1: parser error : Start tag expected, '<' not found
BEGIN:VCARD

It looks like something is trying to parse vformat as XML. GPE has not changed so I am assuming it is a problem in xmlformat. My suspicion is that it has something to do with the following extract from the trace which seems to show a vevent20 object being incorrectly detected as xml format:

[1231112125.090427]                             Received change gpe-event-70, changetype 1, format vevent20, objtype event from membe
r 2
[1231112125.090452]                             >>>>>>>  osync_format_env_detect_objformat_full(0x1317650, 0x7f5470001760, 0x41d59f00
)
[1231112125.090476]                                     We cannot copy the change, falling back to memcpy
[1231112125.090501]                                     >>>>>>>  osync_format_env_detect_objformat(0x1317650, 0x7f5470001280)
[1231112125.090527]                                             running detector plain for format vevent20
[1231112125.090550]                                             >>>>>>>  osync_converter_detect(0x131c2a0, 0x7f5470001280)
[1231112125.090572]                                             <<<<<<<  osync_converter_detect: 0x1318000
[1231112125.090594]                                     <<<<<<<  osync_format_env_detect_objformat: 0x1318000
[1231112125.090622]                                     >>>>>>>  osync_converter_invoke(0x131c610, 0x7f5470001280, (NULL), 0x41d59f00)
[1231112125.090645]                                             Converter of type 3, from 0x1318000(plain) to 0x1318e50(xmlformat-contact-doc)
[1231112125.090670]                                     <<<<<<<  osync_converter_invoke
[1231112125.090691]                                     >>>>>>>  osync_format_env_detect_objformat(0x1317650, 0x7f5470001280)
[1231112125.090713]                                     <<<<<<<  osync_format_env_detect_objformat: No detector triggered
[1231112125.090737]                             <<<<<<<  osync_format_env_detect_objformat_full: 0x1318e50
[1231112125.090758]                             Detected format (xmlformat-contact-doc) different then the reported format (vevent20)!

Config files and full traces can be supplied if required.

[dgollub]

Decapsulate-conversion seems to succeed xmlformat-contact-doc:

Converter of type 3, from 0x1318000(plain) to 0x1318e50(xmlformat-contact-doc)

For that reason the format got "renamed" to xmlformat-contact-doc. Need to review the decapsulate-function ... the check seems to be to weak.

[Graham Cobb]

For clarification: this error is being reported during the "Get Changes" phase. The error occurs once for every change gpe-sync reports.

[dgollub]

Should be fixed with r5007.