Changeset 3313

Timestamp:

05/04/08 01:33:46 (3 months ago)

Author:

dgollub

Message:

Hashtable API consumer sanity checks.

Files:

• trunk/opensync/helper/opensync_hashtable.c (modified) (3 diffs)

trunk/opensync/helper/opensync_hashtable.c

@@ -351 +351 @@
-                g_hash_table_insert(table->db_entries, uid, hash);
-        }
+        osync_list_free(result);
-
-        osync_trace(TRACE_EXIT, "%s", __func__);
@@ -449 +450 @@
-        const char *uid = osync_change_get_uid(change);
-        const char *hash = osync_change_get_hash(change);
+
+        osync_assert_msg(uid, "Some plugin forgot to set the UID for the change. Please report this bug.");
-
-        switch (osync_change_get_changetype(change)) {
@@ -470 +473 @@
-                        break;
-                case OSYNC_CHANGE_TYPE_MODIFIED:
+                        osync_assert_msg(hash, "Some plugin forgot to set the HASH for the change for the changetype MODIFIED. Please report this bug.");
-                        /* This works even if the UID/key is new to the hashtable */
-                        g_hash_table_replace(table->db_entries, g_strdup(uid), g_strdup(hash));
-                        break;
-                case OSYNC_CHANGE_TYPE_ADDED:
+                        osync_assert_msg(hash, "Some plugin forgot to set the HASH for the change for the changetype ADDED. Please report this bug.");
-                        g_hash_table_insert(table->db_entries, g_strdup(uid), g_strdup(hash));
-                        break;